-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds definitions for node terminology and links #1031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge improvement - nice work @Annamarie2019.
I caught a couple small typos and such, but nothing major.
I'm a "more links the merrier" kind of guy, so that seems all good :)
As far as "instances" go, that's kind of a tricky one... in my head, an "instance" is the actual running code / process, executing on a specific machine at a point in time. So, if I upgrade from say go-ipfs 0.4 to 0.5, I've replaced my old instance with a new one. But, since I haven't changed my "identity" key, it's still the same "node" as far as the IPFS network is concerned.
I'm not sure if everyone shares that definition... @johnnymatthews what do you think? At any rate, I think the definition you used is better than the nothing that we have now 😄
|
In addition to addressing #245: Disambiguating nodes, peers, instances, vs. daemons, I also made it a little more user friendly....so it also makes a little bit of a dent in #951: Simplify the Concept/Nodes page. I add definitions of various node terms, move types next (I think those are easier to understand than the Go and JS implementations), and I add a sentence about what implementations have to do with nodes. There may be more that someone can do for #951.
I will not be surprised if the reviewer makes several requests. I'm aware of these things: